Update storage-aws.md #2992
Merged
Update storage-aws.md #2992
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pracucci
approved these changes
Aug 10, 2020
Contributor
pracucci
left a comment
pracucci
left a comment
There was a problem hiding this comment.
Thanks! I would just suggest to link the blocks storage 🙏
docs/production/storage-aws.md
Outdated
Comment on lines
23
to
24
Contributor
There was a problem hiding this comment.
Suggested change
| Using just S3 is not an option, unless you use the experimental "blocks" | |
| storage engine. | |
| Using just S3 is not an option, unless you use the experimental [blocks storage engine](../blocks-storage/). |
Contributor
|
@amckinley Would you mind fixing DCO please, so that we can merge this? You can also use |
pstibrany
approved these changes
Aug 20, 2020
Contributor
pstibrany
left a comment
pstibrany
left a comment
There was a problem hiding this comment.
LGTM, with Marco's suggestion about the link.
forestsword
reviewed
Aug 28, 2020
docs/production/storage-aws.md
Outdated
There was a problem hiding this comment.
Suggested change
| Note that the choices for the chunks stoage backend are: "chunks" of | |
| Note that the choices for the chunks storage backend are: "chunks" of |
Improve clarity around blocks vs chunks storage options.
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Contributor
|
I'm taking over this PR to get it merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve clarity around blocks vs chunks storage options.